Emit ipc_strategy attribute and refactor execute flow#3124
Open
p3dr0rv wants to merge 2 commits into
Open
Conversation
Contributor
p3dr0rv
commented
May 18, 2026
p3dr0rv
commented
- Set the existing AttributeName.ipc_strategy on the DeviceRegistrationIpc span when an IPC strategy succeeds, making it easy to identify the winning strategy.
- Refactor communicateProtocolWithStrategy into sendProtocolRequestToBroker to separate bundle packing from IPC transport. Packing now happens once before the strategy loop instead of on every retry.
- Move cache update and unpack back into execute for clarity.
- Set the existing AttributeName.ipc_strategy on the DeviceRegistrationIpc span when an IPC strategy succeeds, making it easy to identify the winning strategy. - Refactor communicateProtocolWithStrategy into sendProtocolRequestToBroker to separate bundle packing from IPC transport. Packing now happens once before the strategy loop instead of on every retry. - Move cache update and unpack back into execute for clarity.
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves device registration IPC observability and execution structure in the Common Android library by emitting the winning IPC strategy as an OpenTelemetry attribute and refactoring the execute flow to avoid repeated bundle packing across strategy retries.
Changes:
- Emit
AttributeName.ipc_strategyon theDeviceRegistrationIpcspan when an IPC strategy succeeds. - Refactor IPC execution by splitting “pack parameters” from “send over IPC” (
communicateProtocolWithStrategy→sendProtocolRequestToBroker) and packing once before the retry loop. - Move cache update and protocol response unpacking back into
execute()for clearer control flow.
Contributor
Author
|
@copilot add changelog entry |
Agent-Logs-Url: https://github.com/AzureAD/microsoft-authentication-library-common-for-android/sessions/6dd246a9-5bac-444e-b216-cf553bc469f6 Co-authored-by: p3dr0rv <76129899+p3dr0rv@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.