[minor] [feature]: Update IdentityCore submodule for userObjectId in WPJ metadata#2965
[minor] [feature]: Update IdentityCore submodule for userObjectId in WPJ metadata#2965Veena11 wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates MSAL versioning/packaging metadata to 2.10.0 alongside an IdentityCore submodule pointer update intended to add userObjectId support in WPJ metadata.
Changes:
- Bump MSAL version to 2.10.0 across CocoaPods spec, internal version macros, and iOS/macOS Info.plists.
- Update SwiftPM binary target URL/checksum to the 2.10.0 release artifact.
- Add a new 2.10.0 section at the top of the changelog.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Package.swift | Updates SwiftPM binary target to point at the 2.10.0 MSAL.zip artifact/checksum. |
| MSAL/src/MSAL_Internal.h | Bumps internal version macro from 2.9.x to 2.10.0. |
| MSAL/resources/mac/Info.plist | Updates macOS framework short version string to 2.10.0. |
| MSAL/resources/ios/Info.plist | Updates iOS framework short version string to 2.10.0. |
| MSAL.podspec | Bumps CocoaPods version to 2.10.0. |
| CHANGELOG.md | Creates a 2.10.0 entry at the top of the changelog and adds a new bullet. |
| ## [2.10.0]: | ||
| * Add changes in podspec to support swift files added in common-core #2846 | ||
| * Add a property in MSAL global config allowing 1st party apps to opt into using bound app refresh tokens #2896 | ||
| * Add error handling for MSALErrorServerInvalidRequestResetPasswordRequired, error code mapping for STS error 50142 (SecureChangePasswordDueToConditionalAccess) #2867 | ||
| * Add French cloud environment in MSALAADAuthority #2898 | ||
| * Fix a bug when registering MFA in webview #2908 |
There was a problem hiding this comment.
Issue: The 2.10.0 changelog entry doesn’t mention the primary change described in this PR (IdentityCore submodule update adding userObjectId support in WPJ metadata), but does add an unrelated bullet (“Fix a bug when registering MFA in webview #2908”).
Impact: The release notes become misleading for consumers and make it hard to trace the source of the WPJ metadata change.
Recommendation: Update the 2.10.0 section to include a bullet for the IdentityCore WPJ metadata/userObjectId update, and ensure the listed bullets match the actual scope of this PR (or adjust the PR title/description if this is intended to be a broader 2.10.0 release aggregation).
…stant Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…adata Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Veena11
force-pushed
the
veena/objectid-in-wpj-metadata
branch
from
a693941 to
8834ac2
Compare
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| @@ -1 +1 @@ | |||
| Subproject commit 98578b628dd8bef95033eb8cc7249a89f1da7c83 | |||
There was a problem hiding this comment.
This pull request does not update CHANGELOG.md.
Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.
…TION_USER_OBJECT_ID rename Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
MSAL/IdentityCore:1
- The submodule pointer update should preserve the exact formatting of the
Subproject commit ...line (including leading whitespace). The diff changes indentation, which can cause noisy diffs and may be rejected by tooling that expects the canonical format produced bygit submodule update. Consider updating the submodule via standard git submodule commands so the file contains exactlySubproject commit <sha>with no unexpected indentation changes.
…metadata # Conflicts: # MSAL/IdentityCore
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
Updates the IdentityCore submodule pointer to include
userObjectIdsupport inMSIDWPJMetadata.This is a submodule pointer update for the changes in IdentityCore PR: AzureAD/microsoft-authentication-library-common-for-objc#1797
Changes
MSID_WPJ_REGISTERED_USER_OBJECT_ID_KEYbroker constantuserObjectIdproperty onMSIDWPJMetadataMSIDWorkPlaceJoinUtilBaseMSIDWorkPlaceJoinUtilTestsTesting