[MAJOR] [Feature]: ASWebAuth URL Error for Mobile Onboarding#2991
Open
swasti29 wants to merge 4 commits into
Open
[MAJOR] [Feature]: ASWebAuth URL Error for Mobile Onboarding#2991swasti29 wants to merge 4 commits into
swasti29 wants to merge 4 commits into
Conversation
![azure-pipelines[bot]](https://avatars.githubusercontent.com/in/9426?s=60&v=4){kind=small}
| @@ -1 +1 @@ | |||
| Subproject commit 7ae861d6208e571956655dd3cc83304e248efa61 | |||
There was a problem hiding this comment.
This pull request does not update CHANGELOG.md.
Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an MSAL internal error code to represent an invalid ASWebAuthenticationSession URL scenario and wires it up in MSALErrorConverter so IdentityCore can surface that condition through MSAL’s error taxonomy.
Changes:
- Added
MSALInternalErrorInvalidASWebAuthenticationURLtoMSALInternalErrorin the publicMSALError.hheader. - Mapped
MSIDErrorInvalidASWebAuthenticationURL→MSALInternalErrorInvalidASWebAuthenticationURLinMSALErrorConverter’s error-code mapping table.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MSAL/src/public/MSALError.h | Introduces a new internal error enum value documenting invalid ASWebAuthenticationSession URL usage. |
| MSAL/src/MSALErrorConverter.m | Adds a mapping so the new IdentityCore error code is converted into the MSAL internal error code path. |
Veena11
approved these changes
May 19, 2026
added 2 commits
May 19, 2026 01:42
| Error is thrown when PSSO user registration attempted with no biometrics configured and sekey biometric policy is configured | ||
| */ | ||
| MSALErrorPSSOBiometricsNotEnrolled = -42744, | ||
|
|
| MSALErrorPSSOBiometricsNotEnrolled = -42744, | ||
|
|
||
| /** | ||
| Error is thrown when ASWebAuthenticationSession is attempted to be used with invalid URL, which is not valid https scheme, or the URL is not in allowed domains. |
| @(MSIDErrorUINotSupportedInExtension): @(MSALInternalErrorUINotSupportedInExtension), | ||
| @(MSIDErrorInsufficientDeviceStrength): @(MSALErrorInsufficientDeviceStrength), | ||
| @(MSIDErrorMDMEnrollmentCompletedNeedsRetry): @(MSALErrorMDMEnrollmentCompletedNeedsRetry), | ||
| @(MSIDErrorInvalidASWebAuthenticationURL): @(MSALInternalErrorInvalidASWebAuthenticationURL), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (must be completed before review)
PR Title Format
Required Format:
[Keyword1] [Keyword2]: Descriptionmajor,minor, orpatch(case-insensitive)feature,bugfix,engg, ortests(case-insensitive)Examples:
[MAJOR] [Feature]: new API[minor] [bugfix]: fix crash[PATCH] [tests]: add coverageProposed changes
Describe what this PR is trying to do.
Type of change
Risk
Additional information