wheels: bump cache key to force AMReX rebuild with new arch settings#295
Merged
Conversation
The cache key included only a manual version suffix (v10/v5). Changes to -DAMReX_CUDA_ARCH and -DAMReX_EB did not invalidate the cache, so the cached AMReX from before EB was being reused. This explains why the T4 hit "named symbol not found" — the cached AMReX only had sm_80 SASS (from the original arch75-80 build) but no PTX for backward JIT. Bump v10→v11 (GPU) and v5→v6 (CPU) to force fresh AMReX builds with the actual current flags (EB=ON, arch=75;80 for AMReX with 80-real;75-virtual for OpenImpala).
Code Coverage ReportGenerated by CI — coverage data from gcovr |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cache key included only a manual version suffix (v10/v5). Changes to -DAMReX_CUDA_ARCH and -DAMReX_EB did not invalidate the cache, so the cached AMReX from before EB was being reused. This explains why the T4 hit "named symbol not found" — the cached AMReX only had sm_80 SASS (from the original arch75-80 build) but no PTX for backward JIT.
Bump v10→v11 (GPU) and v5→v6 (CPU) to force fresh AMReX builds with the actual current flags (EB=ON, arch=75;80 for AMReX with 80-real;75-virtual for OpenImpala).