Skip to content

hotfix: Timetable NPE 수정 (main) #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soundbar91 merged 2 commits into from
May 20, 2025
Merged

hotfix: Timetable NPE 수정 (main) #1570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
159f944
fix: 커스텀 강의 시간이 없는 경우 빈값 반환
Soundbar91 May 20, 2025
2b0eea2
fix: 졸업학점 계산기 정규 강의가 없는 경우 강의 시간 []으로 추가
Soundbar91 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/in/koreatech/koin/domain/graduation/service/GraduationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ private TimetableLecture createTimetableLecture(GradeExcelData data, Lecture lec
TimetableFrame graduationFrame, CourseType courseType, GeneralEducationArea generalEducationArea) {
return TimetableLecture.builder()
.classTitle(data.classTitle())
.classTime(lecture != null ? lecture.getClassTime() : null)
.classTime(lecture != null ? lecture.getClassTime() : "[]")
.professor(data.professor())
.grades(data.credit())
.isDeleted(false)
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/in/koreatech/koin/domain/timetableV3/dto/response/LectureInfoResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ public static List<LectureInfoResponse> getCustomLectureInfo(String classTime, S
}

List<Integer> classTimes = parseToIntegerList(classTime);
if (classTimes.isEmpty()) {
return Collections.emptyList();
}
List<LectureInfoResponse> response = new ArrayList<>();

List<String> classPlaces = getClassPlaces(classPlace, classTimes);
Expand Down
Loading