Skip to content

[Fix] 스프링부트4 & 스프링7 버전 호환 문제 해결 #28

Merged
BGMSound merged 8 commits into
mainfrom
develop
Jul 1, 2026
Merged

[Fix] 스프링부트4 & 스프링7 버전 호환 문제 해결 #28
BGMSound merged 8 commits into
mainfrom
develop

Conversation

@BGMSound

@BGMSound BGMSound commented Jul 1, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings July 1, 2026 06:51
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Test Results

45 tests   45 ✅  9s ⏱️
12 suites   0 💤
12 files     0 ❌

Results for commit 4c7e15a.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Code Coverage Report

Overall Project 50.89% -1.82% 🍏
Files changed 65.28% 🍏

Module Coverage
Kover Gradle Plugin XML report for : 71.46% -1.29% 🍏
Kover Gradle Plugin XML report for :documentify-project:documentify-core 30.69% -2.73% 🍏
Files
Module File Coverage
Kover Gradle Plugin XML report for : WebTestClientDocumentResult.kt 100% 🍏
WebTestClientDocumentEmitter.kt 92.6% -1.27% 🍏
SpecElement.kt 84.71% 🍏
AbstractDocumentResult.kt 80.77% -17.48% 🍏
AbstractDocumentifySupport.kt 58.33% 🍏
ResourceSpec.kt 57.27% 🍏
Header.kt 0% 🍏
FieldSchema.kt 0% -23.53%
Kover Gradle Plugin XML report for :documentify-project:documentify-core SpecElement.kt 84.71% 🍏
AbstractDocumentResult.kt 67.13% -21.33% 🍏
WebTestClientDocumentEmitter.kt 0.85% -8.46%
AbstractDocumentifySupport.kt 0% 🍏
WebTestClientDocumentResult.kt 0% 🍏
Header.kt 0% 🍏
FieldSchema.kt 0% -23.53%
ResourceSpec.kt 0% -2.27%

@BGMSound
BGMSound merged commit 2755b8a into main Jul 1, 2026
3 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Documentify’s core behavior and tests to improve compatibility with newer Spring Boot / Spring versions by making schema naming deterministic, improving date sample serialization, and relaxing numeric equality matching during JSONPath validation.

Changes:

  • Bump project version to 1.4.1.
  • Serialize LocalDate / LocalDateTime samples as ISO strings without surrounding quotes (via a configured shared ObjectMapper).
  • Replace strict equalToObject-style value assertions with matcher-based equality that treats numeric types (Int/Long/BigDecimal/Double) as numerically equivalent, with added tests.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
gradle.properties Bumps library version to 1.4.1.
documentify-project/documentify-core/src/test/kotlin/io/github/bgmsound/documentify/core/FieldTest.kt Adds coverage for ISO date/time sample formatting behavior.
documentify-project/documentify-core/src/test/kotlin/io/github/bgmsound/documentify/core/DocumentResultTest.kt Adds coverage for numeric vs non-numeric matcher equality behavior.
documentify-project/documentify-core/src/main/kotlin/io/github/bgmsound/documentify/core/specification/schema/ResourceSpec.kt Makes request/response schema titles deterministic (removes random suffix usage).
documentify-project/documentify-core/src/main/kotlin/io/github/bgmsound/documentify/core/specification/FieldSchema.kt Makes optionalField(description) return Field (consistent with other DSL helpers).
documentify-project/documentify-core/src/main/kotlin/io/github/bgmsound/documentify/core/specification/element/SpecElement.kt Introduces shared ObjectMapper configured for ISO date/time serialization; strips quotes for date samples.
documentify-project/documentify-core/src/main/kotlin/io/github/bgmsound/documentify/core/specification/element/header/Header.kt Reorders newHeader parameters (description before sample).
documentify-project/documentify-core/src/main/kotlin/io/github/bgmsound/documentify/core/emitter/WebTestClientDocumentResult.kt Removes now-unneeded expectValue override after matcher-based validation change.
documentify-project/documentify-core/src/main/kotlin/io/github/bgmsound/documentify/core/emitter/WebTestClientDocumentEmitter.kt Adjusts request header application and ensures alternative response docs include both response snippets and resource snippet.
documentify-project/documentify-core/src/main/kotlin/io/github/bgmsound/documentify/core/emitter/AbstractDocumentResult.kt Centralizes JSONPath validation into matcher-based logic; adds numeric-equality matcher.
documentify-project/documentify-core/src/main/kotlin/io/github/bgmsound/documentify/core/AbstractDocumentifySupport.kt Removes an empty companion object.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 24 to 28
init {
summary = ""
val randomSuffix = randomSuffix()
request.schema = "$documentName Request ($randomSuffix)"
response.schema = "$documentName Response ($randomSuffix)"
request.schema = "$documentName Request"
response.schema = "$documentName Response"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants