Implement G4Trap and G4Trd support in geometries through convexpolyhedron#331

Open

ggalgoczi wants to merge 25 commits into

mainfrom

g4trap-to-convexpolyhedron

Commits on Jun 5, 2026

feat(CSG): add G4Trap support via CSG_CONVEXPOLYHEDRON plane storage
ggalgoczi
committed
fix(CSG): 0-based planeIdx for ConvexPolyhedron import
ggalgoczi
committed
fix(u4): correct G4Trap alpha-shear sign in init_Trap vertex computation
ggalgoczi
committed
feat(u4): add G4Trd via shared ConvexPolyhedron plane helper
ggalgoczi
committed
test: add run_validate.mac with boundary InvokeSD for G4-vs-GPU comparison
ggalgoczi
committed
test(GPURaytrace): write per-event G4 photon hits to g4_hits_output.txt
ggalgoczi
committed
test: G4Trap / G4Trd validation suite (G4 vs Opticks)
ggalgoczi
committed
test(scint): drop synthetic scint yield to 100 photons/MeV + add 5-event macro
ggalgoczi
committed
test(script): pass macro path to run_cherenkov_or_scint so scint uses 5-event macro
ggalgoczi
committed
fix(GPURaytrace): mutex-guard G4 hits file writer for MT runs
ggalgoczi
committed
test(script): cherenkov uses MT macro now that the G4 hit writer is mutex-guarded
ggalgoczi
committed
test(scint): final yield=10 photons/MeV (validated G4-vs-GPU 0.91% diff, chi2/ndf<5)
ggalgoczi
committed
fix(scint gdml): add Geant4 10.x property aliases for Opticks U4Scint
ggalgoczi
committed
test(eps): change defaults to eps=0.001 + MAX_BOUNCE=10000, ABSLENGTH=100m
ggalgoczi
committed
test: consolidate validation suite to iso + scintillation
ggalgoczi
committed
test: add full-physics scintillation test for trd
ggalgoczi
committed
test(script): update config path to share/simphony/config
ggalgoczi
committed
test: ABSLENGTH=100m in iso GDMLs too (was 1km; matches scint GDMLs)
ggalgoczi
committed
style: clang-format touched lines (Microsoft style, repo .clang-format)
ggalgoczi
committed
test(scint trap): tilt symmetry axis (theta=10deg, phi=30deg)
ggalgoczi
committed
ci: run g4trap_validation.sh in PR test matrix
ggalgoczi
committed
chore(config): ship trap_iso torch config from source, drop runtime install
ggalgoczi
committed
fix(tests): use unqualified binary names so g4trap_validation works in CI image
ggalgoczi
committed
fix(tests): don't force CUDA_VISIBLE_DEVICES=1 in g4trap_validation.sh
ggalgoczi
committed

Commits on Jun 6, 2026

refactor(tests): address g4trap review feedback
ggalgoczi
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement G4Trap and G4Trd support in geometries through convexpolyhedron#331

Implement G4Trap and G4Trd support in geometries through convexpolyhedron#331
ggalgoczi wants to merge 25 commits into
mainfrom
g4trap-to-convexpolyhedron

Commits on Jun 5, 2026

feat(CSG): add G4Trap support via CSG_CONVEXPOLYHEDRON plane storage

fix(CSG): 0-based planeIdx for ConvexPolyhedron import

fix(u4): correct G4Trap alpha-shear sign in init_Trap vertex computation

feat(u4): add G4Trd via shared ConvexPolyhedron plane helper

test: add run_validate.mac with boundary InvokeSD for G4-vs-GPU comparison

test(GPURaytrace): write per-event G4 photon hits to g4_hits_output.txt

test: G4Trap / G4Trd validation suite (G4 vs Opticks)

test(scint): drop synthetic scint yield to 100 photons/MeV + add 5-event macro

test(script): pass macro path to run_cherenkov_or_scint so scint uses 5-event macro

fix(GPURaytrace): mutex-guard G4 hits file writer for MT runs

test(script): cherenkov uses MT macro now that the G4 hit writer is mutex-guarded

test(scint): final yield=10 photons/MeV (validated G4-vs-GPU 0.91% diff, chi2/ndf<5)

fix(scint gdml): add Geant4 10.x property aliases for Opticks U4Scint

test(eps): change defaults to eps=0.001 + MAX_BOUNCE=10000, ABSLENGTH=100m

test: consolidate validation suite to iso + scintillation

test: add full-physics scintillation test for trd

test(script): update config path to share/simphony/config

test: ABSLENGTH=100m in iso GDMLs too (was 1km; matches scint GDMLs)

style: clang-format touched lines (Microsoft style, repo .clang-format)

test(scint trap): tilt symmetry axis (theta=10deg, phi=30deg)

ci: run g4trap_validation.sh in PR test matrix

chore(config): ship trap_iso torch config from source, drop runtime install

fix(tests): use unqualified binary names so g4trap_validation works in CI image

fix(tests): don't force CUDA_VISIBLE_DEVICES=1 in g4trap_validation.sh

Commits on Jun 6, 2026

refactor(tests): address g4trap review feedback