Skip to content

Consolidate band formula at Formula/band.rb#5

Merged
kshahbw merged 2 commits into
mainfrom
fix/consolidate-band-formula
Apr 17, 2026
Merged

Consolidate band formula at Formula/band.rb#5
kshahbw merged 2 commits into
mainfrom
fix/consolidate-band-formula

Conversation

@kshahbw
Copy link
Copy Markdown
Contributor

@kshahbw kshahbw commented Apr 17, 2026

Summary

Two duplicate band formulas ended up on the tap after the v0.0.1-beta release:

  • Formula/band.rb — the placeholder committed when the tap was initially set up, with dummy v0.0.3-beta URLs and zero'd SHAs.
  • band.rb at the root — the real formula for v0.0.1-beta, added by GoReleaser PR SWI-10615 Brew formula update for cli version v0.0.1-beta #4, with correct download URLs and checksums.

Homebrew prefers Formula/ over the repo root, so brew install Bandwidth/tap/band resolves to the placeholder and fails trying to download v0.0.3-beta (which doesn't exist).

This PR:

  • Replaces Formula/band.rb with the contents of the root band.rb (the real v0.0.1-beta formula with correct URLs + SHAs)
  • Deletes the root band.rb

Follow-up on the cli side

A matching change is being opened on Bandwidth/cli's .goreleaser.yml — adding directory: Formula to the brews block — so future releases write to Formula/band.rb directly and don't re-create the root copy.

Test plan

  • Merge
  • brew update && brew install Bandwidth/tap/band installs v0.0.1-beta successfully
  • band version prints 0.0.1-beta

Two duplicate formulas existed after the v0.0.1-beta release:

- `Formula/band.rb` — placeholder committed when the tap was set up,
  with dummy `v0.0.3-beta` URLs and zero'd SHAs.
- `band.rb` at root — just-published formula with real v0.0.1-beta
  URLs and correct checksums, added by GoReleaser PR #4.

Homebrew prefers `Formula/` over the repo root, so `brew install
Bandwidth/tap/band` was resolving to the placeholder and failing with
`404 v0.0.3-beta`. Move the GoReleaser-generated formula into
`Formula/band.rb` (replacing the placeholder) and delete the root
copy.

A matching change on Bandwidth/cli's `.goreleaser.yml` (adding
`directory: Formula`) will keep future releases writing to the same
location, so we don't re-introduce the duplicate.
@kshahbw kshahbw requested review from a team as code owners April 17, 2026 18:55
@bwappsec
Copy link
Copy Markdown

bwappsec commented Apr 17, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

joshraub-bw
joshraub-bw previously approved these changes Apr 17, 2026
tdewire
tdewire previously approved these changes Apr 17, 2026
@kshahbw kshahbw dismissed stale reviews from tdewire and joshraub-bw via 266a39f April 17, 2026 18:58
@kshahbw kshahbw merged commit 9ff0329 into main Apr 17, 2026
2 checks passed
@kshahbw kshahbw deleted the fix/consolidate-band-formula branch April 17, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants