Skip to content

fix the display utility (not import in style)#478

Merged
cedric07 merged 1 commit intomasterfrom
fix/display
Apr 1, 2026
Merged

fix the display utility (not import in style)#478
cedric07 merged 1 commit intomasterfrom
fix/display

Conversation

@cedric07
Copy link
Copy Markdown
Contributor

@cedric07 cedric07 commented Apr 1, 2026

Fix de l'utilitaire display qui ne fonctionnait pas, car oublié d'être importé dans le fichier style.scss


Note

Low Risk
Low risk: SCSS-only changes that mainly ensure the display utility is included in the compiled stylesheet and slightly adjust how its display: none rules are emitted.

Overview
Fixes the display utility classes by actually including 04-utilities/display in style.scss, so .is-mobile-only / .is-desktop-only are compiled into the main stylesheet.

Also simplifies 04-utilities/_display.scss by removing the m-style-only dependency and applying display: none !important directly inside the breakpoint mixins.

Written by Cursor Bugbot for commit ab417cc. This will update automatically on new commits. Configure here.

Summary by Sourcery

Ensure display utility classes are compiled and simplify their SCSS implementation.

Bug Fixes:

  • Include the display utility in the main stylesheet so responsive visibility classes like mobile-only and desktop-only work as intended.

Enhancements:

  • Simplify display utility SCSS by inlining the display rules and removing the m-style-only mixin dependency.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 1, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Includes the display utility SCSS module in the main stylesheet and simplifies how display: none is applied for mobile/desktop visibility helper classes.

Class diagram for updated display utility visibility helpers

classDiagram
    class m_breakpoint {
        <<mixin>>
        breakpoints(breakpoint_name, mode)
    }

    class is_mobile_only {
        <<scss_class>>
        +display none_important
        +applies_below mobile_to_desktop_nav
    }

    class is_desktop_only {
        <<scss_class>>
        +display none_important
        +applies_at_or_above mobile_to_desktop_nav
    }

    m_breakpoint <.. is_mobile_only : uses_breakpoints
    m_breakpoint <.. is_desktop_only : uses_breakpoints
Loading

File-Level Changes

Change Details Files
Simplified the display utility SCSS so breakpoint-based visibility helpers apply display rules directly, removing a dependency on the style-only mixin.
  • Removed the unused m-style-only SCSS module import
  • Inlined display: none !important directly inside the breakpoint mixins for .is-mobile-only and .is-desktop-only
src/scss/04-utilities/_display.scss
Ensured the display utility classes are compiled into the main stylesheet by importing their SCSS module.
  • Added the 04-utilities/display module to the list of utilities used by the primary style.scss entrypoint
src/scss/style.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@cedric07 cedric07 merged commit 9827547 into master Apr 1, 2026
8 checks passed
@cedric07 cedric07 deleted the fix/display branch April 1, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants