Skip to content

Node.js 24.14.1 and 25.9.0#35

Open
jwaisner wants to merge 1 commit intomainfrom
april
Open

Node.js 24.14.1 and 25.9.0#35
jwaisner wants to merge 1 commit intomainfrom
april

Conversation

@jwaisner
Copy link
Copy Markdown
Contributor

No description provided.

@jwaisner jwaisner requested a review from N6REJ as a code owner April 12, 2026 22:38
@qodo-code-review
Copy link
Copy Markdown
Contributor

Review Summary by Qodo

Add Node.js versions 24.14.1 and 25.9.0 support

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Add Node.js version 24.14.1 with configuration and launch scripts
• Add Node.js version 25.9.0 with configuration and launch scripts
• Update bundle release version to 2026.4.12
• Register new Node.js versions in releases.properties
Diagram
flowchart LR
  A["Node.js 24.14.1"] --> B["Configuration Files"]
  A --> C["Launch Scripts"]
  A --> D["NPM Config"]
  E["Node.js 25.9.0"] --> B
  E --> C
  E --> D
  B --> F["releases.properties"]
  C --> F
  D --> F
  G["build.properties"] --> F
Loading

Grey Divider

File Changes

1. bin/nodejs24.14.1/launch.bat ⚙️ Configuration changes +12/-0

Launch script for Node.js 24.14.1

bin/nodejs24.14.1/launch.bat


2. bin/nodejs24.14.1/bearsampp.conf ⚙️ Configuration changes +8/-0

Bearsampp configuration for Node.js 24.14.1

bin/nodejs24.14.1/bearsampp.conf


3. bin/nodejs24.14.1/etc/npmrc ⚙️ Configuration changes +4/-0

NPM configuration for Node.js 24.14.1

bin/nodejs24.14.1/etc/npmrc


View more (11)
4. bin/nodejs24.14.1/etc/npmrc.ber ⚙️ Configuration changes +4/-0

NPM backup configuration for Node.js 24.14.1

bin/nodejs24.14.1/etc/npmrc.ber


5. bin/nodejs24.14.1/node_modules/npm/npmrc ⚙️ Configuration changes +1/-0

NPM module configuration for Node.js 24.14.1

bin/nodejs24.14.1/node_modules/npm/npmrc


6. bin/nodejs24.14.1/node_modules/npm/npmrc.ber ⚙️ Configuration changes +1/-0

NPM module backup configuration for Node.js 24.14.1

bin/nodejs24.14.1/node_modules/npm/npmrc.ber


7. bin/nodejs25.9.0/launch.bat ⚙️ Configuration changes +12/-0

Launch script for Node.js 25.9.0

bin/nodejs25.9.0/launch.bat


8. bin/nodejs25.9.0/bearsampp.conf ⚙️ Configuration changes +8/-0

Bearsampp configuration for Node.js 25.9.0

bin/nodejs25.9.0/bearsampp.conf


9. bin/nodejs25.9.0/etc/npmrc ⚙️ Configuration changes +4/-0

NPM configuration for Node.js 25.9.0

bin/nodejs25.9.0/etc/npmrc


10. bin/nodejs25.9.0/etc/npmrc.ber ⚙️ Configuration changes +4/-0

NPM backup configuration for Node.js 25.9.0

bin/nodejs25.9.0/etc/npmrc.ber


11. bin/nodejs25.9.0/node_modules/npm/npmrc ⚙️ Configuration changes +1/-0

NPM module configuration for Node.js 25.9.0

bin/nodejs25.9.0/node_modules/npm/npmrc


12. bin/nodejs25.9.0/node_modules/npm/npmrc.ber ⚙️ Configuration changes +1/-0

NPM module backup configuration for Node.js 25.9.0

bin/nodejs25.9.0/node_modules/npm/npmrc.ber


13. build.properties ⚙️ Configuration changes +1/-1

Update bundle release version to 2026.4.12

build.properties


14. releases.properties ⚙️ Configuration changes +2/-0

Register Node.js 24.14.1 and 25.9.0 releases

releases.properties


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Copy Markdown
Contributor

qodo-code-review bot commented Apr 12, 2026

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)   🖥 UI issues (0)   🎨 UX Issues (0)
🐞\ ≡ Correctness (1)

Grey Divider


Remediation recommended

1. Inconsistent release URL 🐞
Description
The 23.11.0 entry in releases.properties uses a release tag path of 2025.4.19 but the archive
filename suffix is 2025.3.2, which is inconsistent with the file’s URL/date pattern and can break
link validation. Because this PR modifies releases.properties, the link-validation workflow will
validate every URL in the file (not just the newly added lines).
Code

releases.properties[R1-4]

+25.9.0 = https://github.com/Bearsampp/module-nodejs/releases/download/2026.4.12/bearsampp-nodejs-25.9.0-2026.4.12.7z
25.8.0 = https://github.com/Bearsampp/module-nodejs/releases/download/2026.3.7/bearsampp-nodejs-25.8.0-2026.3.7.7z
25.2.1 = https://github.com/Bearsampp/module-nodejs/releases/download/2025.12.30/bearsampp-nodejs-25.2.1-2025.12.30.7z
+24.14.1 = https://github.com/Bearsampp/module-nodejs/releases/download/2026.4.12/bearsampp-nodejs-24.14.1-2026.4.12.7z
Evidence
releases.properties contains an internally inconsistent URL for 23.11.0 (tag date != filename
date). The CI workflow that runs on releases.properties changes reads the entire file and performs
HTTP validation for each URL, so this pre-existing inconsistent entry becomes a risk for this PR
once the file is touched.

releases.properties[10-10]
.github/workflows/validate-properties-links.yml[77-143]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`releases.properties` has an entry for `23.11.0` whose download URL release tag date (`.../download/2025.4.19/`) does not match the archive filename date suffix (`...-2025.3.2.7z`). When `releases.properties` is modified (as in this PR), CI validates **all** URLs in the file, so this inconsistency is likely to cause validation failures or confusion.

### Issue Context
- The file is semver-sorted and appears to consistently use the same `{bundle.release}` date in both the `releases/download/<date>/...` segment and the archive filename suffix.
- The `23.11.0` entry is a notable exception.

### Fix Focus Areas
- releases.properties[10-10]

### Suggested fix
Update the `23.11.0` line so that the release tag segment and the archive filename segment use the same release date (choose the date that corresponds to the actual GitHub release tag/asset name).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant