Repository navigation
Make the first local run work on any Node.js and stop cleanly on Ctrl+C - #25
Merged
Merged
Conversation
devEngines.runtime downloads the pinned Node.js 24 into the project, so a machine with another Node.js version can run every pnpm command; the doctor and setup errors now point at running through pnpm.
A terminal's Ctrl+C reached the bundled PostgreSQL, and embedded-postgres also stops it on any SIGINT, so the worker lost its connections mid-shutdown and pnpm reported exit 130. The launcher now runs in its own process group and is asked to stop over IPC; the web app and worker run as single direct processes so the database waits for them. Closing the terminal stops them the same way.
The quick start connects Chrome first, explains the extension's debugger and all-sites permissions, and says what to do when another BeatBrowser version is already running. A non-browser request to the workspace now says the app is running instead of reading like an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the friction found by a fresh-clone first-run test of the no-login local edition.
Changes
devEngines.runtimemakes pnpm download the pinned Node.js 24.22.1, checksummed per platform in the lockfile. Everypnpm local:*command uses it, whatever Node.js the system has. On a fresh clone,pnpm local:doctorinstalls dependencies first. The README prerequisites are now Git, pnpm 12.4.1 and Chrome.ERR_PNPM_RECURSIVE_EXEC_FIRST_FAIL/ exit 130. Now:Checks
pnpm test(11 tasks), script tests (18/18), integration tests (47/47).pnpm local:doctor,local:setup,local:start):