-
-
Notifications
You must be signed in to change notification settings - Fork 34
Add block donation feature #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
c9851fe
Initial plan
Copilot c5c6ef2
Fix top ten ordering: use ConcurrentHashMap for thread safety and inv…
Copilot 9c535c5
Merge pull request #403 from BentoBoxWorld/copilot/fix-top-ten-order
tastybento 2fd5615
Initial plan
Copilot d572a33
Fix incorrect block icons for hanging signs, vines, and cave vines
Copilot a4fc233
Merge pull request #404 from BentoBoxWorld/copilot/fix-bamboo-hanging…
tastybento 0d5000d
Initial plan
Copilot f242433
Merge pull request #405 from BentoBoxWorld/copilot/add-placeholder-po…
tastybento a09b0a4
Initial plan
Copilot 76190aa
Add Russian locale file (ru.yml) with MiniMessage formatting
Copilot 449cb18
Merge pull request #407 from BentoBoxWorld/copilot/update-russian-lan…
tastybento 358a0e1
Translate Czech (cs): bring up to date with en-US
tastybento 4f3d815
Translate Spanish (es): bring up to date with en-US
tastybento 8037192
Translate French (fr): bring up to date with en-US
tastybento 64931a1
Translate Dutch (nl): bring up to date with en-US
tastybento b3ec23e
Translate Polish (pl): bring up to date with en-US
tastybento 63a460d
Translate Indonesian (id): bring up to date with en-US
tastybento b9d4ca0
Translate Ukrainian (uk): bring up to date with en-US
tastybento 995c418
Translate Chinese Simplified (zh-CN): bring up to date with en-US
tastybento 4128b1a
Translate Portuguese (pt): bring up to date with en-US
tastybento d00883e
Translate Vietnamese (vi): bring up to date with en-US
tastybento 615dc67
Translate Hungarian (hu): bring up to date with en-US
tastybento b5620a2
Translate German (de): bring up to date with en-US
tastybento 6702b49
Translate Korean (ko): bring up to date with en-US
tastybento 54b50be
Translate Latvian (lv): bring up to date with en-US
tastybento d68da46
Translate Turkish (tr): bring up to date with en-US
tastybento 9c0a5e1
Version 2.24.0
tastybento 322a605
Bump BentoBox to 3.14.0, migrate locales to MiniMessage, refresh Mave…
tastybento 8346ae3
Add block donation feature (#220)
tastybento 9a4ec0f
Sync locales with new donation strings and document panel upgrade caveat
tastybento f0fc85d
Fix donation panel lore color leak and default italic
tastybento 4ae01bb
Confirm hand donations and localize point totals
tastybento f27f8f7
Fix review feedback: donation panel safety, LevelsManager data integr…
Copilot aa92264
Require Member rank minimum on block donation flag
tastybento e68f503
Address Sonar findings on DonationPanel
tastybento bfce0e8
Merge pull request #413 from BentoBoxWorld/feature/flag-minimum-rank
tastybento 2c546e3
Update CLAUDE.md
tastybento 099fc44
Address second review: recalc after donation, fix tab-complete indexi…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
donateBlocks(...)only updates the donation fields and saves the object, but it never triggers a level recalculation or updates the storedlevel/pointsToNextLevelfields. SincegetIslandLevel(...)readsIslandLevels#getLevel(), donations won’t actually affect island level/top-ten output until some later/island levelrecalculation happens. Consider queueing a recalculation here (or in the donate command/panel after a successful donation), or explicitly updating the persisted level fields so the “donation raises level” behavior is immediate and consistent.