Skip to content

Ap 592 fees route #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davezuckerman merged 5 commits into from
Apr 1, 2026
Merged

Ap 592 fees route #40

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7fa544
redirecting if jwt is not see for /fees path
davezuckerman Apr 1, 2026
2b70111
moved missing_params under private
davezuckerman Apr 1, 2026
8d7a504
removed empty space
davezuckerman Apr 1, 2026
ebc5e9f
only redirecting if jwt is missing for the index action for fees
davezuckerman Apr 1, 2026
c8b3680
fixed rubocop indentation error
davezuckerman Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/controllers/fees_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
require 'jwt'

class FeesController < ApplicationController

rescue_from ActionController::ParameterMissing, with: :missing_params
Comment thread
davezuckerman marked this conversation as resolved.
Outdated

# This will be needed for transaction_complete since Paypal will hit that
protect_from_forgery with: :null_session

Expand Down Expand Up @@ -75,6 +78,10 @@ def transaction_complete

private

def missing_params(_error)
redirect_to 'https://lib.berkeley.edu/find/borrow-renew?section=pay-fees', allow_other_host: true
Comment thread
davezuckerman marked this conversation as resolved.
Outdated
end

def authorize!
return if Rails.env.development?

Expand Down
4 changes: 2 additions & 2 deletions spec/request/fees_request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ def base_url_for(user_id = nil)
allow(Rails.application.config).to receive(:alma_api_key).and_return(alma_api_key)
end

it 'shows a Bad Request error if request has no jwt' do
it 'redirects to the fallback URL if there is no jwt' do
get fees_path
expect(response).to have_http_status(:bad_request)
expect(response).to redirect_to('https://lib.berkeley.edu/find/borrow-renew?section=pay-fees')
end

it 'redirects to error page if request has a non-existant alma id' do
Expand Down
Loading