Skip to content

fix: detect plugin entry in new Codex navigation #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luSkyl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: detect plugin entry in new Codex navigation #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions assets/inject/renderer-inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
nativeMenuBar: "[class*=\"ms-auto\"][class*=\"flex\"][class*=\"items-center\"]",
archiveNav: 'button[aria-label="已归档对话"], button[aria-label="Archived conversations"]',
disabledInstallButton: 'button:disabled, button[aria-disabled="true"], [role="button"][aria-disabled="true"], button[data-disabled], [role="button"][data-disabled], button.cursor-not-allowed, [role="button"].cursor-not-allowed, button.pointer-events-none, [role="button"].pointer-events-none',
pluginNavButton: 'nav[role="navigation"] button.h-token-nav-row.w-full',
pluginNavButton: 'button, [role="button"]',
pluginSvgPath: 'svg path[d^="M7.94562 14.0277"]',
};

Expand Down Expand Up @@ -1377,7 +1377,9 @@
}

function pluginEntryButton() {
const byIcon = document.querySelector(`${selectors.pluginNavButton} ${selectors.pluginSvgPath}`)?.closest("button");
const byIcon = Array.from(document.querySelectorAll(selectors.pluginSvgPath))
.map((path) => path.closest(selectors.pluginNavButton))
.find((button) => button && /^(插件|Plugins)(\s+-\s+.*)?$/i.test((button.textContent || "").trim()));
if (byIcon) return byIcon;
return Array.from(document.querySelectorAll(selectors.pluginNavButton))
.find((button) => /^(插件|Plugins)(\s+-\s+.*)?$/i.test((button.textContent || "").trim())) || null;
Expand Down
9 changes: 9 additions & 0 deletions crates/codex-plus-core/tests/cdp_bridge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,15 @@ fn injection_script_skips_plugin_patch_work_in_relay_mode() {
assert!(script.contains("clearPluginPatchArtifacts()"));
}

#[test]
fn injection_script_detects_plugin_entry_without_legacy_nav_class() {
let script = assets::injection_script(57321);

assert!(script.contains("pluginNavButton: 'button, [role=\"button\"]'"));
assert!(script.contains("path.closest(selectors.pluginNavButton)"));
assert!(!script.contains("button.h-token-nav-row.w-full"));
}

#[test]
fn injection_script_unlocks_nested_disabled_plugin_install_buttons() {
let script = assets::injection_script(57321);
Expand Down