fix: remove explicit deploy job permissions & add pre-release note - #26
Merged
Conversation
…lease note. Co-authored-by: Antigravity <gemini@google.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a GitHub Actions permissions parsing issue in the bioccheck.yml reusable workflow by removing an explicit permissions: block from the nested deploy job, and updates the README to clarify the repository is still pre-release.
Changes:
- Removed the
deployjob’s explicit Pages/OIDC permissions so the reusable workflow can be parsed under restricted caller permissions. - Added a pre-release disclaimer note to
README.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Adds a pre-release disclaimer to set expectations ahead of a first stable v1 tag. |
| .github/workflows/bioccheck.yml | Removes job-level GitHub Pages permissions from the deploy job to avoid parse-time permission errors in restricted callers. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions:block from the nesteddeployjob inbioccheck.yml. Jobs in reusable workflows inherit caller permissions by default. Removing explicit permissions allows default callers (e.g.ci.ymlwithenable_pkgdown: false) to parse and run without throwing parse-time permission errors on repos with restricted permissions.