Expose ESMFold2 MSA inference-diversity knobs in local fold()#342
Merged
Conversation
The transformers ESMFold2Model.forward accepts msa_max_depth, msa_column_mask_rate, and msa_subsample_at_inference, but the local ESMFold2InputBuilder.fold() entrypoint didn't surface them, so users running ESMFold2 locally couldn't access the feature. Add the three knobs to fold() and forward them to the model. Defaults match the model's hardcoded values (1024 / 0.1 / True), so behavior is unchanged unless set; they only take effect for inputs that carry an MSA. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Collaborator
Author
|
|
Its model default is True and we always want it on, so omitting the knob is behavior-preserving and leaves fold() exposing exactly msa_max_depth + msa_column_mask_rate, matching the FoldingConfig (forge) interface. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ebetica
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transformers ESMFold2Model.forward accepts msa_max_depth, msa_column_mask_rate, and msa_subsample_at_inference, but the local ESMFold2InputBuilder.fold() entrypoint didn't surface them, so users running ESMFold2 locally couldn't access the feature.
Add the three knobs to fold() and forward them to the model. Defaults match the model's hardcoded values (1024 / 0.1 / True), so behavior is unchanged unless set; they only take effect for inputs that carry an MSA.