fix: dispatch reward commands on main thread for Folia compat (#31)#32
Open
hermes18974-jpg wants to merge 1 commit into
Open
fix: dispatch reward commands on main thread for Folia compat (#31)#32hermes18974-jpg wants to merge 1 commit into
hermes18974-jpg wants to merge 1 commit into
Conversation
Pull request overviewWraps command dispatch in scheduler tasks to ensure execution on the main thread for Folia compatibility. Fixes thread-safety issues where reward commands were being fired from region threads. Changes:
Reviewed changesNo blocking or high-confidence comments. Reviewed 1 changed file in this pull request and generated no inline comments. Generated by pull_request.opened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
Problem
On Folia-based servers, throws because it must run on the global tick thread. Level-up reward commands fire from event handlers on region threads.
Fix
Wrap calls in so they execute synchronously on the main thread.
Verification
/claim #31
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.