Fix(abstract-utxo,utxo-core): add .js extensions for ESM compatibility#8383
Open
0x7365746265726E wants to merge 4 commits intoBitGo:masterfrom
Open
Fix(abstract-utxo,utxo-core): add .js extensions for ESM compatibility#83830x7365746265726E wants to merge 4 commits intoBitGo:masterfrom
0x7365746265726E wants to merge 4 commits intoBitGo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ESM builds in
@bitgo/abstract-utxoand@bitgo/utxo-corefail in Node.js withERR_MODULE_NOT_FOUND.Root cause:
tsconfig.esm.jsonusedmoduleResolution: "bundler"which doesn't require.jsextensions. Node.js ESM requires explicit extensions.Changes:
tsconfig.esm.jsonin both packages:moduleResolutionandmodule→"NodeNext".jsto all relative imports insrc/**/*.tsIssue Number
Fixes #7660
Type of change
How Has This Been Tested?
Happy to add a test case or reproduction repo if useful — let me know preferred approach.
Checklist