feat(statics): add CoinFeature[] overload to getFilteredFeatures#8391
Merged
manas-at-bitgo merged 1 commit intomasterfrom Apr 2, 2026
Merged
Conversation
Allow callers with an existing CoinFeature[] to pass it directly to getFilteredFeatures, bypassing the coin map lookup. Also add ofcFeatures field to Erc20WithOfcConfig so generateERC20 callers can explicitly control OFC coin features. Jira: CSHLD-559 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mukeshsp
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getFilteredFeaturesinmodules/statics/src/ofc.tsto acceptCoinFeature[]directly, in addition to the existingstringsuffix lookupofcFeatures?: CoinFeature[]field toErc20WithOfcConfigingenerateERC20.tsso callers can explicitly control OFC coin features without relying on derivedonChain.featuresTest plan
getFilteredFeaturesshould pass unchangedstringandCoinFeature[]call sitesgenerateERC20coins usingofcFeaturesget expected filtered features on the OFC coinJira: CSHLD-559
🤖 Generated with Claude Code