refactor(wasm-utxo): extract base classes for PSBT and transaction#243
Open
OttoAllmendinger wants to merge 1 commit intomasterfrom
Open
refactor(wasm-utxo): extract base classes for PSBT and transaction#243OttoAllmendinger wants to merge 1 commit intomasterfrom
OttoAllmendinger wants to merge 1 commit intomasterfrom
Conversation
Introduce `PsbtBase` and `TransactionBase` to eliminate duplication across `Psbt`/`BitGoPsbt` and `Transaction`/`ZcashTransaction`/ `DashTransaction`. Common methods (input/output counts, serialization, KV access) are now implemented once in the base classes. On the Rust side, add a `WasmPsbtOps` trait and macro to generate consistent WASM bindings. Move `remove_input`/`remove_output` into the `PsbtAccess` trait for uniformity. Co-authored-by: llm-git <llm-git@ttll.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
PsbtBaseandTransactionBaseto eliminate duplicationacross
Psbt/BitGoPsbtandTransaction/ZcashTransaction/DashTransaction. Common methods (input/output counts, serialization,KV access) are now implemented once in the base classes.
On the Rust side, add a
WasmPsbtOpstrait and macro to generateconsistent WASM bindings. Move
remove_input/remove_outputintothe
PsbtAccesstrait for uniformity.Co-authored-by: llm-git llm-git@ttll.de