[BIT-94] docs(vera): add interim Linear QA bridge#84
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbb8ba24c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 317d94a750
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b196643c14
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex can you fix this to the best of your abilities. It's really not that important since it's just a cheap version of Vera, but the code should at least be consistent and make sense, and the feedback should be addressed. |
Summary
Testing
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca50644da3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…. Reverting to restore them"
|
@codex even when trying to revert the damage I caused I failed. Can you fix all the issues you pointed out, and then just squash and merge forcefully and I will update the linear prompt based off the new prompt template |
Summary
Testing
|
|
Addressed outstanding Codex feedback in : receipt now requires , includes when a PR exists, and explicitly disallows . |
|
Addressed outstanding Codex feedback in vera_linear_pr_review_prompt_v1.md: receipt now requires QA_RESULT=PASSED or QA_RESULT=FAILED, includes PR_URL when a PR exists, and explicitly disallows SKIPPED. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebb613c682
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Do not give a casual “looks good” | ||
| - Every critical acceptance criterion needs either pass evidence or one reproducible failure | ||
| - Optional fix hints are allowed only if obvious and low-risk, max 3 bullets | ||
| - `SKIPPED` is not allowed in the interim bridge |
There was a problem hiding this comment.
Allow SKIPPED in the starter QA receipt template
The starter prompt currently forbids SKIPPED, but the newly added interim bridge contract explicitly requires supporting QA_RESULT=SKIPPED/qa-skipped (including mapping legacy NO_VERDICT outcomes) and the runtime parser accepts SKIPPED in linear/src/engine.py (QA_TOKEN_RE). In cases where QA cannot safely issue pass/fail and should emit a skip-style outcome, following this prompt forces a FAILED result instead, which misclassifies the QA state and drives the wrong workflow transition.
Useful? React with 👍 / 👎.
Summary
Why
This gives Linear a low-cost interim QA path that preserves independent QA authority and a durable verification_report.md artifact without trying to rebuild the full Zulip-era orchestration yet.
Notes