Clean up unused Zemeroth demo artifacts#29
Conversation
|
leocagli
left a comment
There was a problem hiding this comment.
Thanks @YfengJ — the cleanup direction is right, but a couple of things to sort out before merging:
Scope exceeded the issue brief
The issue (#28) asked to delete zemeroth.wasm and gl.js only. This PR also renames the entire demo/zemeroth-demo/ folder to demo/human-vs-bots/ and deletes the Zemeroth license files. The rename is actually a good idea (it reflects what the folder really is), but it needs to be a conscious decision.
Merge conflict risk
PRs #30 and #31 both add/modify files under demo/zemeroth-demo/. If this merges first under the new path, those PRs will conflict and need to be rebased. We need to coordinate order.
Next steps
- Confirm: is the folder rename intentional? If yes, we'll ask #30 and #31 to rebase against this branch before we merge this one.
- If you want to keep the scope minimal: split into two commits — one that only deletes
wasm+gl.js, and a second for the rename — so we can cherry-pick if needed.
Either way, the work looks solid. Just need alignment on scope and order.



Closes #28.
Summary
demo/zemeroth-demotodemo/human-vs-botszemeroth.wasm,gl.js) and the unreferenced RON/font payload left with that demo folderserve-zemeroth.shwithserve-human-vs-bots.shValidation
bash -n scripts/serve-human-vs-bots.sh scripts/serve-demos.sh scripts/game-studio.shtest -f demo/human-vs-bots/index.htmltest ! -e demo/zemeroth-demotest ! -e THIRD_PARTY_ZEMEROTH_LICENSE_MIT.txttest ! -e THIRD_PARTY_ZEMEROTH_LICENSE_APACHE.txt! rg -n "zemeroth|Zemeroth|serve-zemeroth" README.md index.html scripts demo -Sgit diff --cached --checkpython3 -m http.serverand confirmed/,/demo/human-vs-bots/,game.js, andstyles.cssall resolve./scripts/serve-human-vs-bots.shand confirmed the direct demo page serves withgame.js