Skip to content

fix: validate address checksums before decoding#5

Open
1507819106zxzx-crypto wants to merge 1 commit into
BitgesellOfficial:betafrom
1507819106zxzx-crypto:fix-address-checksum-validation
Open

fix: validate address checksums before decoding#5
1507819106zxzx-crypto wants to merge 1 commit into
BitgesellOfficial:betafrom
1507819106zxzx-crypto:fix-address-checksum-validation

Conversation

@1507819106zxzx-crypto
Copy link
Copy Markdown

Summary

  • Validate addresses with isAddressValid before addressToHash decodes them.
  • Surface address invalid from addressToScript when checksum validation fails.
  • Add regression coverage for P2PKH, P2SH, and Bech32 checksum-invalid inputs.

Verification

  • npm test
  • npm run build

Related bounty: BitgesellOfficial/bitgesell#39
Payout address if approved: 0x4451dF3D21925eF7a62D20eEdc80B99f7140C5D2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants