Filter unsupported OSC output from host-shell - #16
Conversation
Modern Linux login shells emit terminal metadata such as systemd OSC 3008 markers. Track escape state across reads and remove OSC sequences before writing output to the Amiga console.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 545ac922d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Bytes 0x9C and 0x9D can be UTF-8 continuation bytes. Recognize only the 7-bit OSC forms emitted by the PTY so multibyte output remains intact.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00eea6ec9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Track UTF-8 continuation bytes inside discarded OSC payloads. A standalone 0x9C ends OSC while encoded 0x9C bytes remain payload.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd1af9213b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Track UTF-8 continuation bytes in text state so standalone 0x9D starts OSC without dropping valid UTF-8 output.
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
host-shell.Root cause
Modern Linux login shells can emit OSC metadata such as systemd's OSC 3008 command markers.
host-shelltranslated ANSI CSI sequences but forwarded OSC bytes unchanged. Because the Amiga console does not understand OSC, it displayed the metadata payload as ordinary text.Escape sequences can cross
HostShell_Read()boundaries, so filtering each buffer independently would still leak partial metadata.User impact
Interactive host shells no longer display systemd command metadata, terminal titles, or similar OSC payloads. Normal text and supported CSI formatting continue to work, including when an escape sequence is split across reads.
Validation
make testsacredbanana/amiga-compiler:m68k-amigaoshost-shellcross-build with the same imagegit diff --checkRelated