Skip to content

Harden Host-Tools for the 2.6 release - #17

Merged
midwan merged 3 commits into
masterfrom
release/2.6-hardening
Jul 22, 2026
Merged

Harden Host-Tools for the 2.6 release#17
midwan merged 3 commits into
masterfrom
release/2.6-hardening

Conversation

@midwan

@midwan midwan commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

What

  • Centralizes release metadata in version.mk and advances the suite to 2.6.
  • Verifies every packaged command, the AmigaGuide, and mhiuae.library before archiving.
  • Makes clean native tests work on x86-64 and ARM64 compiler containers.
  • Pins GitHub Actions dependencies, validates tag/version agreement, and publishes SHA-256 checksums.
  • Preserves clipboard trailing newlines, bounds/cancels captured host commands, and keeps host-shell within the trap limit.
  • Makes host-download transactional, restricts supported protocols, and protects existing FORCE destinations until commit.
  • Writes the POSIX host-env store atomically with mode 0600 and rejects multiline values.
  • Fixes MHI completion signaling and UAESND initialization cleanup.
  • Refreshes README and AmigaGuide content, and adds a changelog and release checklist.

Why

The published v2.5 archive carried 2.4 version strings because the tag changed only the archive filename. A clean test run also exposed an ARM64 native-compiler selection problem and a recursive MHI package-directory collision. The runtime review found additional data-integrity, timeout, and driver-lifecycle edge cases worth resolving before the next release.

Root cause

Release metadata was duplicated and never checked against staged artifacts. Native-test selection assumed x86-64, recursive make inherited a generic package variable, and several host bridges treated asynchronous operations as if they completed synchronously.

Impact

This is release hardening with two intentional input changes: host-download accepts HTTP, HTTPS, FTP, and FTPS only, and host-env values must be single-line. Existing download destinations remain untouched until a successful replacement is ready. No installer destinations or component choices change.

Checks

  • Clean make test package in sacredbanana/amiga-compiler:m68k-amigaos.
  • Native tests compiled and ran with aarch64-linux-gnu-gcc in the ARM64 image.
  • All 11 commands plus mhiuae.library were built for AmigaOS 3.
  • The 32-file Host-Tools-2.6.lha archive passed layout and 2.6 version-string verification.
  • A deliberate 2.5 metadata expectation was rejected.
  • Generated POSIX shell commands passed syntax and behavior tests.
  • Workflow YAML parsed successfully.

midwan added 2 commits July 22, 2026 14:43
Prevent stale release metadata and partial overwrites from reaching artifacts. Tighten host command handling and driver lifecycle behavior, with regression coverage and release documentation.
@midwan
midwan marked this pull request as ready for review July 22, 2026 11:46
@midwan
midwan marked this pull request as draft July 22, 2026 11:46
@midwan midwan self-assigned this Jul 22, 2026
@midwan
midwan marked this pull request as ready for review July 22, 2026 11:46

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d51c8fc2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/host_download_command.h Outdated
@midwan
midwan marked this pull request as draft July 22, 2026 13:37
@midwan
midwan marked this pull request as ready for review July 22, 2026 13:50
@midwan

midwan commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 856b4cf598

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@midwan
midwan merged commit 52a805c into master Jul 22, 2026
2 checks passed
@midwan
midwan deleted the release/2.6-hardening branch July 22, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant