Skip to content

Fix host-env get argument validation - #19

Merged
midwan merged 1 commit into
masterfrom
fix/host-env-get
Jul 22, 2026
Merged

Fix host-env get argument validation#19
midwan merged 1 commit into
masterfrom
fix/host-env-get

Conversation

@midwan

@midwan midwan commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the value validation accidentally applied to host-env get
  • add native coverage that invokes the real host-env CLI entry point
  • record the correction in the v2.6 changelog

Root cause

The get branch accepts host-env get NAME, so argc is 3 and argv[3] is
the terminating null pointer. A value-validation check introduced during release
hardening treated that absent argument as invalid and returned before building
the host command.

Impact

host-env get NAME once again reads existing host variables. The regression
test mocks only the Amiberry traps and exercises the production argument
dispatch and command-building path, covering both get and set.

Validation

  • confirmed the failure manually in Amiberry before the fix
  • docker run --rm -v "$PWD":/work -w /work sacredbanana/amiga-compiler:m68k-amigaos make clean test package
  • rebuilt and verified Host-Tools-2.6.lha
  • git diff --check

@midwan
midwan merged commit 7a5e04f into master Jul 22, 2026
2 checks passed
@midwan
midwan deleted the fix/host-env-get branch July 22, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant