Fix host-env get argument validation - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
host-env gethost-envCLI entry pointRoot cause
The
getbranch acceptshost-env get NAME, soargcis 3 andargv[3]isthe terminating null pointer. A value-validation check introduced during release
hardening treated that absent argument as invalid and returned before building
the host command.
Impact
host-env get NAMEonce again reads existing host variables. The regressiontest mocks only the Amiberry traps and exercises the production argument
dispatch and command-building path, covering both
getandset.Validation
docker run --rm -v "$PWD":/work -w /work sacredbanana/amiga-compiler:m68k-amigaos make clean test packageHost-Tools-2.6.lhagit diff --check