Terminate host-env get output cleanly - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
host-env getoutput with one newlineWhy
Manual Amiberry release testing confirmed that variable retrieval works after
the argument-validation fix, but the Amiga Shell prompt was rendered directly
after the value. Values are restricted to one line, so presenting the result as
one complete output line is clearer and consistent with the other tools.
Impact
host-env get NAMEnow displays the value cleanly before the next Amiga Shellprompt. Missing variables retain their existing failure behavior and exit code.
Validation
value with spaces\nConsole.Out.WriteLinedocker run --rm -v "$PWD":/work -w /work sacredbanana/amiga-compiler:m68k-amigaos make clean test packageHost-Tools-2.6.lhagit diff --check