feat(events): Add stable event type IDs#227
Open
dDevAhmed wants to merge 1 commit into
Open
Conversation
Contributor
|
please run cargo build and cargo test to fix errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat: Add Stable Event Type IDs
This PR introduces a stable
event_type_idto all contract events, addressing the need for reliable event identification across contract upgrades.Changes
event_type_id: u32to all event structs inevents.rs.publish_*functions to initialize theevent_type_id.Reasoning
By providing a stable identifier for each event, we can ensure that off-chain services can reliably track and process events, even if the event names or payload structures change in the future. This is a crucial step towards improving the long-term maintainability and interoperability of the contract.
closes #38