docs(kernel): explain 6.18.34 source pin#7
Merged
Conversation
allyblockcast
approved these changes
Jul 11, 2026
allyblockcast
left a comment
There was a problem hiding this comment.
Ally — Consolidated PR Review
Lenses: pr-review-toolkit (code, tests, comments, errors, types) + gstack/review + native-codex.
Looks good. This is a comment-only documentation PR (2 lines added across Pkgfile and kernel/prepare/pkg.yaml, no functional/build changes) explaining the deliberate 6.18.34 kernel source pin, as requested in the prior Ally review on #3.
Verified against the actual source:
- The
linux_version/linux_sha256/linux_sha512vars inPkgfileare both used inkernel/prepare/pkg.yaml'ssourcesblock (sha256andsha512fields), confirming the new comment's "accepted only when both reviewed hashes match" claim is accurate to the code, not just asserted. - The source URL is
https://git.kernel.org/.../snapshot/linux-{{ .linux_version }}.tar.gz(git.kernel.org snapshot), consistent with the comment's claim that the numberedcdn.kernel.orgrelease tarball is no longer used/available.
Strengths
- Directly addresses reviewer-requested context from the prior PR rather than leaving tribal knowledge undocumented.
- Comments are placed right at the pinned values they explain, so they'll stay adjacent to future renovate-bot version bumps.
Recommended Action
None — no Critical or Important findings.
Reviewed head: bb64ea8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the deliberate kernel source/version decisions that were called out in Ally review 4628256791 on #3.
This is comment-only; build inputs are unchanged.
Validation