Open
Conversation
Include the LSP's JIT channel opening fee in the lsp_invoice response so clients can display the negotiated fees when presenting an invoice. The fee is computed from the selected LSP's LSPS2 fee parameters using max(min_fee_msat, ceil(amount * proportional / 1_000_000)). When the node has sufficient incoming capacity and no JIT channel is needed, the fee is reported as 0. Also surfaces the fee through gl-sdk's ReceiveResponse for UniFFI bindings consumers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds a unified list_payments API that fetches invoices (received) and pays (sent) via CLN RPCs, merges them into a common Payment type, and applies in-memory filtering by type, time range, status, with pagination support. This is part of the migration from Breez SDK. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests verify that all new UniFFI types (ListPaymentsRequest, Payment, PaymentType, PaymentStatus, PaymentTypeFilter) are correctly exposed in Python bindings, including field construction and enum variants. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
Contributor
No worries, merge yours as it includes changes to the node if I understand correctly and I'll create a PR if needed. My wild guess is that I need some extra stuff from the invoice eg. Destination public key |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_paymentsmethod to gl-sdkNodethat fetches invoices (received) and pays (sent) via CLN RPCs, merges them into a unifiedPaymenttype, and applies in-memory filteringTest plan
cargo build -p gl-sdkcompiles cleanlytests/test_list_payments.py) verifying UniFFI type exposure, enum variants, and record constructionlist_paymentsend-to-end🤖 Generated with Claude Code