Locomotion fixes (walk/sprint) + camera canopy occlusion#13
Conversation
The ANIMDBG harness was left true in a merge: it auto-starts the game, makes the player immortal, scripts a walk/sprint cycle, spams ANIMDBG lines to stdout and sets waveBreakTimer = 9999 - no enemy ever spawns, so main did not actually play. The harness itself stays for the walk/sprint investigation; flip the const back locally to resume it. Claude-Session: https://claude.ai/code/session_018574BdCfSjdpNK3WLgx1hP
Shooter half of the locomotion investigation (engine half - the anim_play mid-fade restart that pinned every pose at t=0 - is already on engine main): - Climb assist is now derived from the GROUND NORMAL: the vertical rate needed to follow the surface is h * (-(n.dir_h)/n.y), exactly zero on flat ground. The old flat 0.45*speed lifted 2.0 m/s on level ground, so the player was airborne ~3 of every 4 walking frames in a permanent invisible hop - and sprint, gated on grounded, was unreachable. That, not the sprint code, is why shift did nothing. - Camera canopy occlusion: trees only have a trunk collider, so the orbit raycast flew through the leaves and parked the camera inside the foliage. The orbit now tests analytic canopy cylinders (bounds MEASURED from each GLB''s leaf-card primitive) and sweeps a 5-ray probe fan (the camera is a volume, not a point) against static geometry, with a proper minimum orbit distance. - ANIMDBG harness documents the solved investigation, gains the CAMHOLD sub-mode and orbit readback, and returns to its dormant state (false) per the shipped-builds contract. Claude-Session: https://claude.ai/code/session_018574BdCfSjdpNK3WLgx1hP
|
Warning Review limit reached
Next review available in: 30 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Lands the walk/sprint investigation (shooter half; the engine mixer fix rode to engine main in Bloom-Engine/engine#94) plus the camera canopy work:
grounded, so sprint was unreachable. The assist is nowh * (-(n.dir_h)/n.y): exactly zero on flat ground, exactly the surface-following rate on a slope, capped on steep ground.Smoke-verified: waves spawn, locomotion drives, RT path tracing clean, no harness output.
https://claude.ai/code/session_018574BdCfSjdpNK3WLgx1hP