Skip to content

Feature/picker#136

Open
mhusnainnnaseer786 wants to merge 11 commits into
developfrom
feature/picker
Open

Feature/picker#136
mhusnainnnaseer786 wants to merge 11 commits into
developfrom
feature/picker

Conversation

@mhusnainnnaseer786

@mhusnainnnaseer786 mhusnainnnaseer786 commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

Description

This pr will add Picker component in React native paper.

Screenshots (if appropriate):

Screenshot from 2019-10-24 14-14-03

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mhusnainnnaseer786

Copy link
Copy Markdown
Contributor Author

Sir @artalat ,
If I render children in picker with mode="dialog" | "menu" then it through an error . Because children are of PickerItem type which needs Picker as their Parent and in our case parent is dailog or menu.

@ammarkhan967 ammarkhan967 added enhancement New feature or request Feature something new is added labels Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Feature something new is added

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants