Feature/picker component #56
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,4 +39,7 @@ dist/ | |
| .expo | ||
|
|
||
| # Jest | ||
| .jest | ||
|
|
||
| # storybook Loader | ||
| .bluebase/storybook-native/storybook/storyLoader.js | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| export default { | ||
| plugins: [ | ||
| require('../../src')] | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,194 @@ | ||
| import * as React from 'react'; | ||
|
|
||
| import { List, ListItem, Picker, Text, View, } from '@bluebase/components'; | ||
| import { Modal, TouchableOpacity, ViewStyle } from 'react-native'; | ||
|
|
||
| import { Theme } from '@bluebase/core'; | ||
|
|
||
| export interface ItemsProps { | ||
| value: string, label: string | ||
| } | ||
| export interface PickerStyles { | ||
| picker: ViewStyle, | ||
| overlay: ViewStyle | ||
| actionSheetOverlay: ViewStyle, | ||
| } | ||
|
|
||
|
|
||
|
|
||
| export interface PickerProps { | ||
| items: ItemsProps[], | ||
| selectedValue: string, | ||
| styles: PickerStyles, | ||
| label: string, | ||
| mode: 'modal' | 'actionsheet'; | ||
| onValueChange: (data: string, index: number) => void | ||
| } | ||
|
|
||
| export interface PickerState { | ||
| selectedValueIndex?: number | ||
| textStyle?: string | ||
| modalVisible?: boolean | ||
| selectedValue: string | ||
| selected?: string | ||
|
|
||
| } | ||
| export class PickerComponent extends React.Component<PickerProps, PickerState> { | ||
| constructor(props: PickerProps) { | ||
| super(props); | ||
|
|
||
| this.state = { | ||
| modalVisible: false, | ||
| selected: '', | ||
| selectedValue: '', | ||
| }; | ||
| } | ||
|
|
||
| static defaultStyles = (_theme: Theme) => ({ | ||
| container: { | ||
| backgroundColor: '#fff', | ||
|
Contributor
There was a problem hiding this comment. Why are colours hard coded |
||
| borderColor: '#ddd', | ||
| borderTopWidth: 0.5, | ||
|
Contributor
Author
There was a problem hiding this comment. the colors are hard coded because android does not have any actionsheet effect so just to make it applicable i have made in modal and poped up through bottom
Contributor
There was a problem hiding this comment. So what happens on dark theme? We cannot hardcode Colors. Or themeing will not work |
||
| justifyContent: 'center', | ||
| minHeight: 40, | ||
| padding: 5, | ||
| }, | ||
| overlay: { | ||
| backgroundColor: 'rgba(0,0,0,0.5)', | ||
| flex: 1, | ||
| justifyContent: 'center', | ||
| width: null, | ||
| }, | ||
| actionSheetOverlay: { | ||
| backgroundColor: 'rgba(0,0,0,0.5)', | ||
| flex: 1, | ||
| justifyContent: 'flex-end', | ||
| width: null, | ||
| }, | ||
| picker: { | ||
| backgroundColor: 'white', | ||
| borderColor: '#aaa', | ||
| borderTopWidth: 0.5, | ||
| padding: 10, | ||
| }, | ||
|
|
||
| }) | ||
|
|
||
| onValueChange = (data: string, index: number) => { | ||
| this.setState({ modalVisible: false, selectedValue: data, selected: data }); | ||
| this.props.onValueChange(data, index); | ||
| } | ||
| renderDropdownPicker = () => { | ||
| const { items } = this.props; | ||
| return ( | ||
| <Picker | ||
| selectedValue={this.state.selected} | ||
| onValueChange={this.onValueChange} | ||
| > | ||
| { | ||
| items.map((item: { label: string, value: string }, i: number) => | ||
| <Picker.Item key={i} label={item.label} value={item.value} /> | ||
| ) | ||
| } | ||
| </Picker> | ||
| ); | ||
| } | ||
|
|
||
|
|
||
|
|
||
| renderActionSheetPicker = () => { | ||
| const { items, label, styles } = this.props; | ||
| return ( | ||
| <> | ||
| <View testID="list-id"> | ||
| <List> | ||
| <List.Item | ||
| title={label} | ||
| description={<Text>{this.state.selected}</Text>} | ||
| onPress={this.dialogHandler} | ||
| /> | ||
| </List> | ||
| </View> | ||
| <Modal transparent visible={this.state.modalVisible} animationType="fade"> | ||
| <TouchableOpacity activeOpacity={1} onPress={this.dialogHandler} style={styles.actionSheetOverlay}> | ||
| <View style={styles.picker}> | ||
| { | ||
| items.map((item: { label: string, value: string }, i: number) => ( | ||
| <List> | ||
| <ListItem key={i} title={item.label} onPress={this.onPressHandler(i)} /> | ||
| </List> | ||
|
|
||
| ) | ||
| ) | ||
| } | ||
| </View> | ||
|
|
||
| </TouchableOpacity> | ||
| </Modal> | ||
| </> | ||
| ); | ||
| } | ||
| onPressHandler = (id: number) => () => { | ||
| this.props.items.map((item: { label: string, value: string }, i: number) => { | ||
| if (id === i) { | ||
| this.setState({ selected: item.label }); | ||
| } | ||
| }); | ||
| this.dialogHandler(); | ||
| } | ||
|
|
||
| renderPicker = () => { | ||
|
|
||
| const picker = { modal: this.renderModalPicker(), actionsheet: this.renderActionSheetPicker() } | ||
|
|
||
| return picker[this.props.mode]; | ||
|
|
||
| } | ||
| renderModalPicker = () => { | ||
| const { items, label, styles } = this.props; | ||
| return ( | ||
| <> | ||
| <View> | ||
| <List> | ||
| <List.Item | ||
| title={label} | ||
| description={<Text>{this.state.selected}</Text>} | ||
| onPress={this.dialogHandler} | ||
| /> | ||
| </List> | ||
| </View> | ||
| <Modal transparent visible={this.state.modalVisible} animationType="fade"> | ||
| <TouchableOpacity activeOpacity={1} onPress={this.dialogHandler} style={styles.overlay}> | ||
| <View style={styles.picker} testID="picker-test"> | ||
| { | ||
| items.map((item: { label: string, value: string }, i: number) => ( | ||
| <List> | ||
| <ListItem key={i} title={item.label} onPress={this.onPressHandler(i)} /> | ||
| </List> | ||
|
|
||
| ) | ||
| ) | ||
| } | ||
|
|
||
| </View> | ||
|
|
||
| </TouchableOpacity> | ||
| </Modal> | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| dialogHandler = () => { | ||
| this.setState({ modalVisible: !this.state.modalVisible }); | ||
| } | ||
|
|
||
| render() { | ||
| const { mode } = this.props; | ||
| return ( | ||
| <> | ||
| {mode ? this.renderPicker() : this.renderDropdownPicker()} | ||
| </> | ||
| ); | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.