Merged
Conversation
* Aka make sure non-required args are actually not required.
* Moved the POD block to the top (before the use statements). * Split the constructor docs into a proper `=head1 CONSTRUCTOR` section with nested `=over`/`=back` for each argument, including the sub-keys of `cmd_schema`. * Added a dedicated `=head1 METHODS` section for `run()` and `validate_args()`. * Added a `=head1 BUILT-IN COMMANDS` section documenting help and quit/exit. * Added a `=head1 TAB COMPLETION` section.
* `Validate_args` / `new()` tests check that all the croak paths fire correctly missing name, missing cmd_schema, wrong types for cmd_schema, exec, args, and get_opts. There's also a positive check that a valid get_opts coderef is accepted without error. * `Construction` sanity checks verify the object is the right class, that the help and quit builtins get injected, and that prompt handling (default and custom) works as expected. * `_tab_complete` tests use a single shared $repl instance at the bottom to avoid reconstructing it repeatedly. They cover command name completion, partial arg completion, no-match cases, and the passthrough ! exclusion.
* Add a `=head1 LICENSE` section to the POD * Add a `=head1 DESCRIPTION` section
* Yeah dunno how that slipped in there, I probably just copied and pasted a bunch of imports from somewhere else and that got left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.