fix: memoize Sparkline's derived rows/config (companion to #3, closes the rest of #2)#4
Open
DloomPlz wants to merge 1 commit into
Open
Conversation
…t Compiler Companion to Boring-Software-Inc#3 (which stabilizes the register/unregister callbacks): Sparkline rebuilds rows/config on every render, and rows identity feeds useRevision's adjust-state-during-render — which never stabilizes when the array is fresh each pass. Memoize both against data/color. Registry JSON regenerated via npm run build.
8a65d05 to
22435f7
Compare
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heads-up
#3 already stabilizes the
registerSeries/unregisterSeries+registerVariant/unregisterVariantcallbacks (nice work @seanryy — I hadn't seen it before opening this, sorry for the noise). This PR is now trimmed down to only the piece #3 doesn't cover, so the two merge cleanly together and fully close #2.Problem
Sparklinerebuilds its derived props every render:Without the compiler,
rowsgets a fresh identity each pass — androwsfeedsuseRevision's adjust-state-during-render, which then never stabilizes: every render bumps the revision, resets the entrance gate, and re-renders. Same class of bug as #2/#3, different entry point (this one triggers even after #3 lands).Fix
Memoize
rows/configwithuseMemoagainstdata/color— exactly what the compiler emits for compiler-enabled projects, so no behavior change there. Registry JSON regenerated withnpm run build.