fix: accept interface-typed rows in the chart generics#5
Open
DloomPlz wants to merge 1 commit into
Open
Conversation
TData extends Record<string, unknown> rejects interface rows — interfaces
don't get an implicit index signature in TypeScript, so e.g.
interface PricePoint { label: string; v: number }
<AreaChart data={points} …> // TS2322: index signature missing
Loosen the public generic constraint to object at the six chart roots and
cast at the controller boundary (the controllers only read row[key] for
configured keys). Type-level only — no runtime change.
Registry JSON regenerated via npm run build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The public chart generics are constrained to
Record<string, unknown>, but TypeScript interfaces don't get an implicit index signature, so interface-typed rows fail to compile:Type-alias rows work (aliases get the implicit signature), which makes the failure feel arbitrary to consumers.
Fix
Loosen the public generic constraint to
objectat the six chart roots, and cast at the controller boundary — the controllers only ever readrow[key]for the configured series/name keys, so the cast is safe. Type-level only; no runtime change. Registry JSON regenerated withnpm run build.