Sourcery refactored main branch#3
Open
sourcery-ai[bot] wants to merge 1 commit into
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| } | ||
|
|
||
| def get_content(self): | ||
| def get_content(self): |
Author
There was a problem hiding this comment.
Function LanguageExpert.get_content refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-326
to
-343
|
|
||
| # Extract the role (as name), system_message, example_input, and example_output from the markdown text | ||
| name = name_pattern.search(markdown_text).group(1).strip() | ||
| role = role_pattern.search(markdown_text).group(1).strip() | ||
| system_message = system_message_pattern.search(markdown_text).group(1).strip() | ||
| example_input = example_input_pattern.search(markdown_text).group(1).strip() | ||
| example_output = example_output_pattern.search(markdown_text).group(1).strip() | ||
|
|
||
| # Create a dictionary with the extracted information, using key names matching the original JSON-like dictionary | ||
| assistant_definition = { | ||
| name = name_pattern.search(markdown_text)[1].strip() | ||
| role = role_pattern.search(markdown_text)[1].strip() | ||
| system_message = system_message_pattern.search(markdown_text)[1].strip() | ||
| example_input = example_input_pattern.search(markdown_text)[1].strip() | ||
| example_output = example_output_pattern.search(markdown_text)[1].strip() | ||
|
|
||
| return { | ||
| 'name': name, | ||
| 'description': role, | ||
| 'system_message': system_message, | ||
| 'example_input': example_input, | ||
| 'example_output': example_output | ||
| 'example_output': example_output, | ||
| } | ||
|
|
||
| return assistant_definition |
Author
There was a problem hiding this comment.
Function parse_assistant_definition refactored with the following changes:
- Replace m.group(x) with m[x] for re.Match objects [×5] (
use-getitem-for-re-match-groups) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
This removes the following comments ( why? ):
# Create a dictionary with the extracted information, using key names matching the original JSON-like dictionary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!