Open
Conversation
added docker secret support to launch.py
Feature/docker secret support
There was a problem hiding this comment.
Pull request overview
Adds support for sourcing Steam credentials from Docker secrets at runtime, along with documentation updates and a Docker build tweak to allow pip installs on Debian Bookworm.
Changes:
- Read
/var/run/secrets/STEAM_USERand/var/run/secrets/STEAM_PASSWORD(when present) and apply them during container startup. - Document Docker secrets usage with a docker-compose example in the README.
- Add
--break-system-packagesto the Dockerfile pip install step to avoid build failures.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
launch.py |
Adds Docker secrets file reads to override Steam credentials at startup. |
README.md |
Documents Docker secrets support and provides a compose snippet. |
Dockerfile |
Adjusts pip install command to work with Debian’s externally-managed Python environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of work