Skip to content

Add tests for autoload#991

Merged
artoonie merged 3 commits intodevelopfrom
feature/issue-981_autoload-tests
Apr 15, 2026
Merged

Add tests for autoload#991
artoonie merged 3 commits intodevelopfrom
feature/issue-981_autoload-tests

Conversation

@artoonie
Copy link
Copy Markdown
Collaborator

@artoonie artoonie commented Mar 25, 2026

Uses the new test harness in #990 to add a regression test for #987.

While the tests fail without #987 merged into this PR, they would pass once #987 is merged in. Not merging them for now to reduce dependencies between PRs until we decide merge order.

This PR:

  1. Creates Common.java for shared test helpers
  2. Creates GuiFunctionalityTests.java for non-tabulation tests, currently only testing autoload but I expect we can use it to test other functionality that only affects the GUI
  3. In GuiConfigController.java, splits out the autoload code into a separate function that can be tested. (For a cleaner diff, make sure you "Hide Whitespace" in github. It's mostly moving code to another function without real changes.)
  4. Updates TabulatorTests to use the new functionality in Common.java
  5. Modifies the CVRs to remove aliases. They're tested elsewhere and they complicate autoload. \CDF and Dominion have "IDs" which autoload will find, creating differences between those formats and ES&S where IDs aren't used. Simpler to simply remove the concept of IDs for these specific tests.

Comment thread src/test/java/network/brightspots/rcv/GuiFunctionalityTests.java Outdated
Comment thread src/test/java/network/brightspots/rcv/Common.java
yezr

This comment was marked as duplicate.

@artoonie artoonie force-pushed the feature/issue-981_autoload-tests branch from aaed1a6 to 8ea80d7 Compare April 8, 2026 14:54
yezr
yezr previously approved these changes Apr 10, 2026
Base automatically changed from feature/same-data-different-format-tests to develop April 10, 2026 16:20
@artoonie artoonie dismissed yezr’s stale review April 10, 2026 16:20

The base branch was changed.

@artoonie artoonie force-pushed the feature/issue-981_autoload-tests branch from 8ea80d7 to 0a006d8 Compare April 13, 2026 16:11
@artoonie artoonie force-pushed the feature/issue-981_autoload-tests branch from 431d0fd to 253975e Compare April 13, 2026 16:19
Copy link
Copy Markdown
Collaborator

@yezr yezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artoonie artoonie added this pull request to the merge queue Apr 15, 2026
Merged via the queue into develop with commit bc23168 Apr 15, 2026
1 check passed
@artoonie artoonie deleted the feature/issue-981_autoload-tests branch April 15, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants