GAUD-10414 - Change default size of side-nav - #7299
Draft
svanherk wants to merge 1 commit into
Draft
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussion with design, we’ve decided to go with a default panel size of 334px for the
side-navpanel (supportingpanel will keep its default of 1/3 the content width).For consumers that set a
state-storage-key, this only really matters the first time you view the page. Once you’ve resized the divider, that stored value will always be used.Since I am going to need the default value in some upcoming
vdiffs, I did refactor to export that calculation rather than repeating it everywhere.You can see the vdiff report here. The
supportingpanel vdiffs don't change, and most of theside-navvdiffs only shift by a pixel because a viewport of 1000 / 3 = 333 lol. But you can see on the largerwidth-typetests that the side nav default no longer grows with the viewport/content.