Add skeleton support to existing date/time functions - #396
Open
bearfriend wants to merge 5 commits into
Open
Conversation
bearfriend
commented
Jul 28, 2026
dlockhart
reviewed
Jul 29, 2026
| const date = new Date(2021, 3, 15, 14, 30); | ||
| let skeleton = 'MMMM'; | ||
| let result = formatDateTimeSkeleton(date, { skeleton, forceUnsupportedFormat: true }); | ||
| expect(result).to.equal('abril'); |
| skeleton = '', | ||
| } = options; | ||
|
|
||
| if (!skeleton) { |
Member
There was a problem hiding this comment.
I'm a bit confused, since I don't see how this branch would be reached unless someone called formatDateTimeSkeleton directly without going through formatDate or formatTime? Is the plan to switch everything to this eventually and then retire formatDate and formatTime?
Contributor
Author
There was a problem hiding this comment.
Yep exactly. Definitely some future-looking stuff there.
Co-authored-by: Dave Lockhart <5491151+dlockhart@users.noreply.github.com>
bearfriend
enabled auto-merge (squash)
July 30, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAUD-10218: Update intl dateTime functions to accept and render from skeleton patterns
For now, we only call
formatDateTimeSkeletonwhen theskeletonoption is explicitly set. Down the road we can start to transition more calls/options to use/convert to skeletons and slowly get rid of the existing custom format handling.