Fix access violation crash when using Ultimate ASI Loader#1
Open
charlesthobe wants to merge 4 commits into
Open
Fix access violation crash when using Ultimate ASI Loader#1charlesthobe wants to merge 4 commits into
charlesthobe wants to merge 4 commits into
Conversation
charlesthobe
force-pushed
the
pr
branch
2 times, most recently
from
284e726 to
1d135f2
Compare
charlesthobe
force-pushed
the
pr
branch
3 times, most recently
from
f8a5d55 to
113d114
Compare
Author
|
I need feedback on whether to resolve datatypes explicitly WriteAt(0x641420, SettingsMgr->fInstances_Spawn_Radius);vs WriteAt<float>(0x641420, SettingsMgr->fInstances_Spawn_Radius);in the first example it figures out that the data is float based on the second argument in the function call. In the latter example the type explicitly stated. |
The code is functionaly the same, no bugs were fixed
This also fixes access violation crash when using newer versions of Ultimate ASI Loader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the game not crash when using newer versions of Ultimate ASI Loader
Rationale for using newer versions of Ultimate ASI Loader; newer versions allow loading modded files without touching original game files as explained here