Handle Google Calendar working locations#1930
Draft
3mdistal wants to merge 2 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Visual recap — skippedThe visual recap job did not run for this pull request. This is informational only and does not block the PR. Recap skipped for |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9936864 to
f3434fd
Compare
f3434fd to
f320661
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eventType=workingLocationevents with nativeworkingLocationProperties, render all-day working locations in a slim translated lane above ordinary all-day events, and keep them non-blocking for availability.This day only, with an explicitAll daysoption that still targets the visible instance ID.workingLocationProperties; the forbidden genericlocationfield is stripped defensively; office metadata is preserved only while the event remains an office location.Verification
pnpm -C templates/calendar test— 38 files, 231 tests passedpnpm -C templates/calendar typecheckpnpm -C templates/calendar buildpnpm guard:i18n-catalogs— 16 catalog directories passedpnpm exec oxfmt --check <18 modified TypeScript files>git diff origin/main --checkorigin/maincompleted cleanly; every local gate above passed again after the final rebase.Browser and provider QA
Accueil,Lieu de travail : Accueil) and restored the app to English afterward.location; Google read-back returned nativeofficeLocation/customLocationproperties withtransparency: transparent.Successful user story
A hybrid worker can scan where they are working separately from all-day commitments, open a focused translated editor, change a visible location from Home to Office or Other, see the chip and pinned detail update immediately, and read the same native non-blocking properties back from Google Calendar. Ordinary multi-day all-day events remain a single continuous span below the location lane.
Review and logs
.task-sweep/calendar-working-location-feedback-ledger.md(local handoff artifact).task-sweep/logs/claude-opus-plan-output-20260709-142915.jsonl.task-sweep/logs/claude-opus-review-final-output-20260709-161320.jsonlVERDICT: NO BLOCKERSRisks and follow-ups
scope: single|all; the UI default was verified read-only on an existing recurring occurrence.