Skip to content

fix(cli): avoid Node shell deprecation warning when running generated scripts #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buyua9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): avoid Node shell deprecation warning when running generated scripts #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/prompt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as p from '@clack/prompts';
import { execaCommand } from 'execa';
import { execa } from 'execa';
import { cyan, dim } from 'kolorist';
import {
getExplanation,
Expand Down Expand Up @@ -40,9 +40,16 @@ async function runScript(script: string) {
p.outro(`${i18n.t('Running')}: ${script}`);
console.log('');
try {
await execaCommand(script, {
const shell =
process.platform === 'win32'
? process.env.ComSpec || process.env.COMSPEC || 'cmd.exe'
: process.env.SHELL || '/bin/sh';
const shellArgs =
process.platform === 'win32' ? ['/d', '/s', '/c', script] : ['-c', script];

// Use an explicit shell process so Node does not emit DEP0190 for shell=true.
await execa(shell, shellArgs, {
stdio: 'inherit',
shell: process.env.SHELL || true,
});
appendToShellHistory(script);
} catch (error) {
Expand Down