Skip to content

Commit d11f8f9

Browse files
authored
Merge pull request #277 from BuildmLearn/fixes
#276 FIXED: Issue with Search in SavedProjects and SavedAPKs + My Drafts
2 parents f63e103 + 7295060 commit d11f8f9

3 files changed

Lines changed: 38 additions & 5 deletions

File tree

source-code/app/src/main/java/org/buildmlearn/toolkit/fragment/DraftsFragment.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ public void onResume() {
179179
if (mAdapter != null) {
180180
reloadContent();
181181
}
182+
setEmptyText();
182183
super.onResume();
183184
}
184185

source-code/app/src/main/java/org/buildmlearn/toolkit/fragment/LoadApkFragment.java

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -365,9 +365,8 @@ public void onTextChanged(CharSequence s, int start, int before, int count) {
365365
public void afterTextChanged(Editable s) {
366366
String text = s.toString().trim();
367367
savedApis.clear();
368-
SavedApi tempApi;
369368
for (int i = 0; i < allsavedApis.size(); i++) {
370-
if (allsavedApis.get(i).getName().contains(text)) {
369+
if (allsavedApis.get(i).getName().toLowerCase().contains(text.toLowerCase())) {
371370
savedApis.add(allsavedApis.get(i));
372371
}
373372
}
@@ -382,6 +381,11 @@ public boolean onKey(View v, int keyCode, KeyEvent event) {
382381
editSearch.onKeyPreIme(keyCode, event);
383382
if (isSearchOpened) {
384383
closeSearch();
384+
savedApis.clear();
385+
for (int i = 0; i < allsavedApis.size(); i++) {
386+
savedApis.add(allsavedApis.get(i));
387+
}
388+
mAdapter.notifyDataSetChanged();
385389
}
386390
return true;
387391
}
@@ -425,11 +429,23 @@ public boolean onKey(View v, int keyCode, KeyEvent event) {
425429
private void deleteItems() {
426430
ArrayList<Integer> selectedPositions = mAdapter.getSelectedPositions();
427431
boolean deleted = false;
432+
428433
for(int selectedPosition : selectedPositions) {
429434
SavedApi apk = savedApis.get(selectedPosition);
430435
File file = new File(apk.getFile().getPath());
431436
deleted = file.delete();
432437
if (deleted) {
438+
int selectedPos = -1;
439+
for (int i = 0; i < allsavedApis.size(); i++) {
440+
SavedApi sApi = allsavedApis.get(i);
441+
if (sApi.getName().equals(apk.getName())) {
442+
selectedPos = i;
443+
break;
444+
}
445+
}
446+
if (selectedPos != -1) {
447+
allsavedApis.remove(selectedPos);
448+
}
433449
savedApis.remove(selectedPosition);
434450
mAdapter.removeSelectedPosition(selectedPosition);
435451
mAdapter.notifyDataSetChanged();

source-code/app/src/main/java/org/buildmlearn/toolkit/fragment/LoadProjectFragment.java

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import android.widget.EditText;
3030
import android.widget.Toast;
3131

32-
3332
import org.buildmlearn.toolkit.R;
3433
import org.buildmlearn.toolkit.ToolkitApplication;
3534
import org.buildmlearn.toolkit.activity.TemplateActivity;
@@ -405,9 +404,8 @@ public void onTextChanged(CharSequence s, int start, int before, int count) {
405404
public void afterTextChanged(Editable s) {
406405
String text = s.toString().trim();
407406
savedProjects.clear();
408-
SavedProject tempProject;
409407
for (int i = 0; i < allsavedProjects.size(); i++) {
410-
if (allsavedProjects.get(i).getName().contains(text)) {
408+
if (allsavedProjects.get(i).getName().toLowerCase().contains(text.toLowerCase())) {
411409
savedProjects.add(allsavedProjects.get(i));
412410
}
413411
}
@@ -422,12 +420,18 @@ public boolean onKey(View v, int keyCode, KeyEvent event) {
422420
editSearch.onKeyPreIme(keyCode, event);
423421
if (isSearchOpened) {
424422
closeSearch();
423+
savedProjects.clear();
424+
for (int i = 0; i < allsavedProjects.size(); i++) {
425+
savedProjects.add(allsavedProjects.get(i));
426+
}
427+
mAdapter.notifyDataSetChanged();
425428
}
426429
return true;
427430
}
428431
return false;
429432
}
430433
});
434+
431435
editSearch.requestFocus();
432436
InputMethodManager imm = (InputMethodManager) getActivity().getSystemService(Context.INPUT_METHOD_SERVICE);
433437
imm.showSoftInput(editSearch, InputMethodManager.SHOW_IMPLICIT);
@@ -466,12 +470,24 @@ public boolean onKey(View v, int keyCode, KeyEvent event) {
466470
private void deleteItems() {
467471
ArrayList<Integer> selectedPositions = mAdapter.getSelectedPositions();
468472
boolean deleted = false;
473+
469474
for(int selectedPosition : selectedPositions) {
470475
SavedProject project = savedProjects.get(selectedPosition);
471476
File file = new File(project.getFile().getPath());
472477
deleted = file.delete();
473478

474479
if (deleted) {
480+
int selectedPos = -1;
481+
for (int i = 0; i < allsavedProjects.size(); i++) {
482+
SavedProject sProject = allsavedProjects.get(i);
483+
if (sProject.getName().equals(project.getName())) {
484+
selectedPos = i;
485+
break;
486+
}
487+
}
488+
if (selectedPos != -1) {
489+
allsavedProjects.remove(selectedPos);
490+
}
475491
savedProjects.remove(selectedPosition);
476492
mAdapter.removeSelectedPosition(selectedPosition);
477493
mAdapter.notifyDataSetChanged();

0 commit comments

Comments
 (0)