Game Autotest#10
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 581ede2a5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| HashSet<ResourceType> reportedUnsupportedTypes = []; | ||
| List<ProbedBundle> probes = ParseYapMeta(bundlePaths, probeRoot); |
There was a problem hiding this comment.
ProbeYapBundles calls ParseYapMeta without any error handling, but ParseYapMeta throws when no .meta.yaml files are found under the probe output. In runs where YAP exits successfully but does not emit metadata (e.g., unsupported/empty probe output), the whole autotest command terminates instead of recording a per-game bundleprobe failure/skip and continuing with other games, which can break batch experiment runs.
Useful? React with 👍 / 👎.
| if (File.Exists(Path.Combine(fullPath, "BurnoutPR.exe")) || | ||
| File.Exists(Path.Combine(fullPath, "BurnoutPR_trial.exe"))) | ||
| { | ||
| return new GameInstall(Path.GetFileName(fullPath), fullPath, Platform.TUB); |
There was a problem hiding this comment.
Using Path.GetFileName(fullPath) directly for GameInstall.Name is unsafe for directory inputs that end with a separator, because it yields an empty string. That produces blank game labels and collapses the work root to the fallback game_<platform>, so multiple same-platform game paths with trailing slashes can reuse the same artifact directory and contaminate each other’s results.
Useful? React with 👍 / 👎.
1 participant
No description provided.