Skip to content

SDL3 desktop frontend#193

Open
cobaltgit wants to merge 15 commits into
ButterscotchRunner:mainfrom
cobaltgit:sdl3
Open

SDL3 desktop frontend#193
cobaltgit wants to merge 15 commits into
ButterscotchRunner:mainfrom
cobaltgit:sdl3

Conversation

@cobaltgit

@cobaltgit cobaltgit commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@cobaltgit cobaltgit marked this pull request as ready for review June 5, 2026 13:16
@cobaltgit

cobaltgit commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

Now with gamepad support (thanks @Eliandro4!)

@cobaltgit

cobaltgit commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

SDL3 now has the most efficient framelimiter according to perf reports..

Un1q32
Un1q32 reviewed Jun 10, 2026
View reviewed changes
Comment thread src/desktop/backends/sdl3.c Outdated
Un1q32
Un1q32 reviewed Jun 10, 2026
View reviewed changes
Comment thread src/desktop/backends/sdl3.c Outdated
@cobaltgit

cobaltgit commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

(minor spelling mistake)

@Un1q32

Un1q32 commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

SDL3 now has the most efficient framelimiter according to perf reports..

If you just use SDL_DelayPrecice for the whole thing does this change? I would imagine DelayPrecice might have logic similar to what we do with sleeping all but the last bit for efficiency. Making it all one function call would be nice to simplify the code.

Un1q32
Un1q32 reviewed Jun 10, 2026
View reviewed changes
Comment thread Makefile Outdated
@cobaltgit

cobaltgit commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

I would imagine DelayPrecice for the whole thing does this change? I would imagine DelayPrecice might have logic similar to what we do with sleeping all but the last bit for efficiency. Making it all one function call would be nice to simplify the code.

Seems like the best call, yeah SDL_DelayPrecise is abit similar to sleeping and then spin-waiting but it's nanosecond-accurate so you don't really need to spin-wait the last <1ms out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Un1q32 Un1q32 Un1q32 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cobaltgit @Un1q32