-
Notifications
You must be signed in to change notification settings - Fork 7
CCSMB-5: PCM Audio Transmissions over modem #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EmmaKnijn
wants to merge
20
commits into
CCSMB:master
Choose a base branch
from
EmmaKnijn:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a170d9f
First iteration
EmmaKnijn 01afc24
Change songName to be more generic
EmmaKnijn 08e8161
Drop the id field
EmmaKnijn b8fab17
Add protocol field and clarify the types in the fields
EmmaKnijn a7a79e5
Enforce protocol to be CCSMB-5
EmmaKnijn 3445da9
Fix markdown formatting
EmmaKnijn 8ca7b64
Restructure compliancy and expand on crosstalk
EmmaKnijn bccaf85
Improve based on some reviews
EmmaKnijn aa863e1
Add port allocation
EmmaKnijn c5a8320
Add a base for the discovery packet
EmmaKnijn 2f87bec
Add a couple things that people requested
EmmaKnijn 1b026dd
Add reference to RFC 2119
EmmaKnijn eb04510
Add clarification for the packet timing
EmmaKnijn 5122823
Change title
EmmaKnijn 70dba1f
Change the protocol name to PASC
EmmaKnijn 779b4e9
Grammatical changes
EmmaKnijn 2d2b02f
Grammatical fix
EmmaKnijn f6179e0
Recommendation on packet length
EmmaKnijn 05e4960
Add multiple channels, clean up some stuff, add example packet
EmmaKnijn 953963f
Enforce 759 for replyChannel
EmmaKnijn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # CCSMB-5: Radio Transmissions | ||
| ```md | ||
| *Author: Emma Beurskens <@emmaknijn>* | ||
| *Version: v1.0.0* | ||
| *Last updated: YYYY-MM-DD* | ||
| ``` | ||
|
EmmaKnijn marked this conversation as resolved.
Outdated
|
||
|
|
||
| ## Design | ||
| A client will only listen to packets while the audio is being transmitted from a server | ||
| The server will communicate to the client over modem | ||
|
EmmaKnijn marked this conversation as resolved.
|
||
|
|
||
| ## Packet | ||
| A packet consists of the following fields in a table: | ||
| - buffer: A table that contains Signed 8-bit PCM @ 48kHz audio | ||
|
EmmaKnijn marked this conversation as resolved.
Outdated
|
||
| - station: A string that contains the name of the radio station | ||
|
EmmaKnijn marked this conversation as resolved.
Outdated
|
||
| - title: A string that contains the song that is currently being played | ||
|
EmmaKnijn marked this conversation as resolved.
Outdated
|
||
| - protocol: A string that contains the protocol used | ||
|
|
||
| The protocol field must be "CCSMB-5" in order to be compliant | ||
| A client must be able to accept the buffer field in order to be compliant | ||
| A server must be able to transmit all of the fields in order to be compliant | ||
| A server must time the packets appropriately in a way that the client is just able to play back the buffer in order to be compliant | ||
| A client must be able to deal with crosstalk | ||
|
EmmaKnijn marked this conversation as resolved.
Outdated
EmmaKnijn marked this conversation as resolved.
Outdated
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.