[APP-818] fix: enable keyboard submit#3422
Merged
Merged
Conversation
mcmcgrath13
changed the title
mcmcgrath13
marked this pull request as ready for review
July 14, 2026 14:39
mcmcgrath13
requested review from
JordanGuinn and
brick-green
and removed request for
a team
July 14, 2026 14:39
JordanGuinn
approved these changes
Jul 15, 2026
JordanGuinn
reviewed
Jul 15, 2026
| ) : status === 'configuring' ? ( | ||
| <FormProvider {...form}> | ||
| <ReportConfigurationPage config={config} handleSubmit={onSubmit} /> | ||
| <form onSubmit={(e) => onSubmit(e, !canRunReport)}> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of #3416 found that keyboard-based submit didn't work. This PR fixes that and adds more robust testing of permissions on the report run page in general
Notes:
form, so moved that out toReportRunPageExportbutton allowed