Skip to content

fix: use user options to populate owner dropdown#3441

Open
emyl3 wants to merge 3 commits into
mainfrom
el/bug-bash/use-user-options-fix
Open

fix: use user options to populate owner dropdown#3441
emyl3 wants to merge 3 commits into
mainfrom
el/bug-bash/use-user-options-fix

Conversation

@emyl3

@emyl3 emyl3 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

  • Changes decision made in this PR

  • Use user options instead of user profile options to populate "Owner" list for creating a report

  • Save as new report flow should properly set the owner to the user creating the report

  • ⚠️ It still displays a blank system owner for our superuser but it should display correctly in the modernized View Report page

Screenshot 2026-07-20 at 16 54 32 Screenshot 2026-07-20 at 16 55 45 Screenshot 2026-07-20 at 16 46 34

Tickets

Checklist before requesting a review

  • PR focuses on a single story
  • Code has been fully tested to meet acceptance criteria
  • PR is reasonably small and reviewable (Generally less than 10 files and 500 changed lines)
  • All new functions/classes/components reasonably small
  • Functions/classes/components focused on one responsibility
  • Code easy to understand and modify (clarity over concise/clever)
  • PRs containing TypeScript follow the Do's and Don'ts
  • PR does not contain hardcoded values (Uses constants)
  • All code is covered by unit or feature tests

@emyl3
emyl3 marked this pull request as ready for review July 20, 2026 21:57
@emyl3
emyl3 requested a review from a team as a code owner July 20, 2026 21:57
@emyl3
emyl3 requested review from JordanGuinn and mcmcgrath13 and removed request for a team July 20, 2026 21:57

@mcmcgrath13 mcmcgrath13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any e2e that can be adapted to add explicit coverage here? (I think superuser is our default login)

@emyl3
emyl3 requested a review from a team as a code owner July 20, 2026 22:48
@emyl3
emyl3 requested review from adaball and krista-skylight and removed request for a team July 20, 2026 22:48
WORKDIR /usr/report-execution

# Install mssql driver deps
RUN microdnf update && microdnf install -y libtool-ltdl krb5-libs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line kept stalling and I tried it locally and after adding this it succeeded locally so trying this here to see if that works in CI as well

@emyl3
emyl3 requested a review from a team as a code owner July 20, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants